Add ChatWithTools provider #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/chat-with-tools
branch
from
6993b75 to
05a9e8b
Compare
marcelklehr
reviewed
Dec 10, 2024
marcelklehr
reviewed
Dec 10, 2024
| @@ -137,6 +138,7 @@ public function translate(?string $fromLanguage, string $toLanguage, string $tex | |||
|
|
|||
| if ($this->openAiAPIService->isUsingOpenAi() || $this->openAiSettingsService->getChatEndpointEnabled()) { | |||
| $completion = $this->openAiAPIService->createChatCompletion($this->userId, $adminModel, $prompt, null, null, 1, PHP_INT_MAX); | |||
| $completion = $completion['messages']; | |||
There was a problem hiding this comment.
summaries will need adjustment too, after edward's PR, I think
There was a problem hiding this comment.
Yes, let's see who merges first.
marcelklehr
reviewed
Dec 10, 2024
marcelklehr
reviewed
Dec 10, 2024
Signed-off-by: Julien Veyssier <[email protected]>
…completion choice Signed-off-by: Julien Veyssier <[email protected]>
…, expect a list of JSON object strings as history Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used by the Agency feature which uses the tooling capabilities of LLMs.
This provider can be tested in the assistant because it dynamically generates a form for the task type (we will hide this task type later).
One small issue: We enforce all the input params but we might wanna set the tool_message (The result of tool calls in the last interaction).
If we give a fake/useless value to the OpenAI API, the request fails because the tool_message does not come after a "tool call" message.
To be discussed.
To test this provider, just replace
$toolMessage = $input['tool_message'];by$toolMessage = null;in the provider and pass a dummy tool_message value in the form.As all input fields have to be defined, also add at least one message in the "chat history".
You can use that in the "tools" input:
[{ "type":"function", "function":{ "description":"get the weather in a city", "name":"get_city_weather" } }]So if you ask for the weather in the city, you should get a tool call as a response. If not, you should get a classic response.